[PATCH] D55900: [MC] Enable .file support on COFF and diagnose it on unsupported targets

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

> However, COFF actually does have some support for this directive, and if you emit an object file, llvm-mc does not assert.

I'm not sure I'm following here - if you emit a COFF object file, from what source? From normal LLVM IR CodeGen, or from MC assembly with a `.file` directive?

> When emitting a COFF object, MC will take those file names and create "debug" symbol table entries for them.

In which cases are these emitted - only if debug info is enabled?

Also I'm a bit confused by the test added - doesn't this test check that it errors out, while the flag that is set to true in `MCAsmInfoCOFF` makes this directive be handled so it shouldn't error out after all?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55900/new/

https://reviews.llvm.org/D55900