[PATCH] D55893: Set hidden attribute on lprofMergeValueProfData

Ana Pazos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 11:16:41 PST 2018


apazos created this revision.

The changes in https://reviews.llvm.org/D44847 cause load time failure
due to lprofMergeValueProfData in Android libs enabled with profile generation:

"dlopen failed: cannot locate symbol "lprofMergeValueProfData" referenced by..."

Marking lprofMergeValueProfData as hidden so the correct in-module definition
 is picked by the linker.


https://reviews.llvm.org/D55893

Files:
  lib/profile/InstrProfilingMergeFile.c


Index: lib/profile/InstrProfilingMergeFile.c
===================================================================
--- lib/profile/InstrProfilingMergeFile.c
+++ lib/profile/InstrProfilingMergeFile.c
@@ -21,6 +21,7 @@
 
 /* Merge value profile data pointed to by SrcValueProfData into
  * in-memory profile counters pointed by to DstData.  */
+COMPILER_RT_VISIBILITY
 void lprofMergeValueProfData(ValueProfData *SrcValueProfData,
                              __llvm_profile_data *DstData) {
   unsigned I, S, V, DstIndex = 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55893.178924.patch
Type: text/x-patch
Size: 524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181219/e44089eb/attachment.bin>


More information about the llvm-commits mailing list