[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

[Clement Courbet via Phabricator via llvm-commits]

courbet marked 6 inline comments as done.
courbet added inline comments.


================
Comment at: lib/AST/TypePrinter.cpp:165
 
+static SplitQualType splitAccordingToPolicy(QualType t,
+                                            const PrintingPolicy &Policy) {
----------------
aaron.ballman wrote:
> `t` doesn't meet the usual naming requirements; how about `QT`?
I was keeping it for consistency with `TypePrinter::print(QualType t,`, but done.


================
Comment at: lib/Sema/SemaTemplate.cpp:3062
 public:
-  explicit FailedBooleanConditionPrinterHelper(const PrintingPolicy &P)
-      : Policy(P) {}
+  FailedBooleanConditionPrinterHelper(const PrintingPolicy &P) : Policy(P) {}
 
----------------
aaron.ballman wrote:
> Why are you dropping the `explicit` here?
Sorry, this is a revert of an approach where it had two parameters.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55552/new/

https://reviews.llvm.org/D55552