[PATCH] D54674: [llvm-objcopy] First bits for MachO

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 01:56:41 PST 2018


alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:130
     return elf::executeObjcopyOnBinary(Config, *ELFBinary, Out);
+  else if (auto *MachOBinary = dyn_cast<object::MachOObjectFile>(&In))
+    return macho::executeObjcopyOnBinary(Config, *MachOBinary, Out);
----------------
jakehehrlich wrote:
> Do we want to be silent on mixed ELF/MachO archives? It's an absurd case that I don't suspect will ever happen it was just a thought I had. I'm fine leaving this as is.
yeah, certainly we can check that, but doesn't seem to be worth it


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674





More information about the llvm-commits mailing list