[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

Wed Dec 19 01:38:32 PST 2018

delcypher marked an inline comment as done.
delcypher added inline comments.

================
Comment at: test/sanitizer_common/CMakeLists.txt:14
+# work don't generate configs for them.
+if (NOT (ANDROID OR WINDOWS))
+  foreach(SANITIZER_TOOL ${SUPPORTED_TOOLS_INIT})
----------------
vitalybuka wrote:
> we run sanitizer_common tests with asan on Android
> I guess we have COMPILER_RT_HAS_UBSAN on android as well, but we don't sanitizer_common tests there
@vitalybuka Oops. Sorry I screwed up there. What would like to do here? If you do ship UBSan on Android I would suggest running the sanitizer_common tests against UBSan. However, I don't have any android devices so I can't easily fix any breakages that this introduces, so perhaps for Android I should use the existing behaviour of only running against ASan?

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740