[PATCH] D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Sorry for the delay.



================
Comment at: lib/CodeGen/ExpandMemCmp.cpp:166
+  // is larger than the max allowed.
+  if ((NumNonOverlappingLoads + !!(Size > 0)) > MaxNumLoads)
+    return {};
----------------
spatel wrote:
> I'm still not clear on this: if Size is 0, does that imply that computeGreedy failed?
A zero size indeed means that greedy should be optimal. The reason why I was handling this case is that it makes `computeOverlappingLoadSequence` stand by itself without having to refer to the greedy approach. But it's true that it duplicates work. So I changed it to bail out.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55263/new/

https://reviews.llvm.org/D55263