[PATCH] D55838: [gn build] Make `ninja check-lld` also run LLD's unit tests

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

Thanks! Actually landing this is blocked on https://reviews.llvm.org/D55836 though.



================
Comment at: llvm/utils/gn/secondary/lld/unittests/DriverTests/BUILD.gn:2
+executable("DriverTests") {
+  # test/Unit/lit.cfg expects unittests in LLD_BINARY_DIR/unittest
+  output_dir = target_out_dir
----------------
phosek wrote:
> If this becomes common we should consider introducing a `test` template.
Every unit test looks like this, so this is a good idea. I'll add a template when I add unit tests for llvm or clang, whatever comes first. (LLD only has two unit test binaries, so waiting until then seems fine to me.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55838/new/

https://reviews.llvm.org/D55838