[LNT] r349574 - Short circuit regression fix checking

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 15:39:23 PST 2018


Author: cmatthews
Date: Tue Dec 18 15:39:23 2018
New Revision: 349574

URL: http://llvm.org/viewvc/llvm-project?rev=349574&view=rev
Log:
Short circuit regression fix checking

If any of these are false, we are returning false, so no point in
checking the rest of them.  This make regression evolution MUCH faster.

Modified:
    lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py

Modified: lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py?rev=349574&r1=349573&r2=349574&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py (original)
+++ lnt/trunk/lnt/server/db/rules/rule_update_fixed_regressions.py Tue Dec 18 15:39:23 2018
@@ -28,7 +28,7 @@ def is_fixed(session, ts, regression):
     fixed?
     """
     r_inds = get_ris(session, ts, regression.id)
-    fixes = [_fixed_rind(session, ts, x) for x in r_inds]
+    fixes = (_fixed_rind(session, ts, x) for x in r_inds)
     return all(fixes)
 
 




More information about the llvm-commits mailing list