[PATCH] D53736: [BTF] Add BTF DebugInfo

[Yonghong Song via llvm-commits]

Eric,

Thanks a lot to you too!

Regards,

Yonghong

On 12/18/18 2:36 PM, Eric Christopher wrote:
> This is really great. I've gotten the review in the next patches.
> 
> Thanks!
> 
> On Sun, Dec 16, 2018 at 9:56 PM Yonghong Song via Phabricator 
> <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> 
>     yonghong-song added a comment.
> 
>     @echristo @aprantl @dblaikie This patch has stuck in this state for
>     more than one month and did not make progress.
>     I have suggested a possible way to move some header files to include
>     directory and then we will be
>     able to move BTFDebug.{cpp,h} under BPF directory. I have
>     implemented this approach with the
>     following three patches for easy to see pro and cons of two approaches:
> 
>        (1) https://reviews.llvm.org/D55755
>     <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D55755&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=0EaggJtLQ0bKjcxygPXQnBNHHPGnsdIapCerhyQd50k&s=aF18j7_zmsMiQJG1Gs5QsCBuNNRr5YaRP90XcvDBMoI&e=>,
>     moving header files
>        (2) https://reviews.llvm.org/D55756
>     <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D55756&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=0EaggJtLQ0bKjcxygPXQnBNHHPGnsdIapCerhyQd50k&s=kWmB3LB_oPywweY9ed5HrWrbO2EUH_9ddOsg4bjCTIM&e=>,
>     changes some fields from private to protected
>        (3) https://reviews.llvm.org/D55752
>     <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D55752&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=0EaggJtLQ0bKjcxygPXQnBNHHPGnsdIapCerhyQd50k&s=dRduTuqkq478vspoEr2QI70KPf2aMWJqaSncIGrEyUI&e=>,
>     changes only under target BPF
> 
>     The new patch series tried to minimize the changes outside the BPF
>     target.
>     I will really appreciate if you can timely review this patch and
>     related other "competing" patches.
>     Thanks!
> 
> 
>     Repository:
>        rL LLVM
> 
>     CHANGES SINCE LAST ACTION
>     https://reviews.llvm.org/D53736/new/
>     <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=0EaggJtLQ0bKjcxygPXQnBNHHPGnsdIapCerhyQd50k&s=BimmGK8ihw_oKooxO--D3ERdSxFqK7jG5GYrDhh_-PI&e=>
> 
>     https://reviews.llvm.org/D53736
>     <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=0EaggJtLQ0bKjcxygPXQnBNHHPGnsdIapCerhyQd50k&s=qtHb20tgrWiaSLHuBEYwaP6O4TFqVgsN1BE5FIjiNP8&e=>
> 
> 
>