[PATCH] D34708: [NVPTX] Allow to make libcalls that are defined in the current module.

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

You probably want to remove libcalls.patch from the patch diff.



================
Comment at: lib/Target/NVPTX/NVPTXInstrInfo.td:2257-2258
+class ProxyRegInst<NVPTXRegClass regclass> :
+  NVPTXInst<(outs regclass:$dst), (ins regclass:$src),
+            "// Proxy Register pseudo instruction",
+            [(set regclass:$dst, (ProxyReg regclass:$src))]>;
----------------
If we ever get here, I think correct asm to generate here should be a move from one register to another.

If we do not expect ProxyReg to ever make it to this point, then we should make the error visible. E.g. fail to lower ProxyReg at all which will cause llvm error.


================
Comment at: test/CodeGen/NVPTX/libcall-instruction.ll:2
 ; RUN: not llc < %s -march=nvptx 2>&1 | FileCheck %s
-; used to panic on failed assetion and now fails with a "Cannot select"
+; used to panic on failed assetion and now fails with a "Undefined external symbol"
 
----------------
Typo/grammar nits:
asse*r*tion
a*n* "Undefined..."  (same issue in in the libcall-intrinsic.ll)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34708/new/

https://reviews.llvm.org/D34708