[llvm] r349545 - Revert r349541 (Fix MSVC dependency issue between Clang-tablegen and LLVM-tablegen)

Alexandre Ganea via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 13:39:40 PST 2018


Author: aganea
Date: Tue Dec 18 13:39:40 2018
New Revision: 349545

URL: http://llvm.org/viewvc/llvm-project?rev=349545&view=rev
Log:
Revert r349541 (Fix MSVC dependency issue between Clang-tablegen and LLVM-tablegen)

Modified:
    llvm/trunk/cmake/modules/TableGen.cmake

Modified: llvm/trunk/cmake/modules/TableGen.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=349545&r1=349544&r2=349545&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/TableGen.cmake (original)
+++ llvm/trunk/cmake/modules/TableGen.cmake Tue Dec 18 13:39:40 2018
@@ -158,12 +158,6 @@ macro(add_tablegen target project)
       llvm_ExternalProject_BuildCmd(tblgen_build_cmd ${target}
                                     ${LLVM_NATIVE_BUILD}
                                     CONFIGURATION Release)
-      # Create an artificial dependency between tablegen projects, because they
-      # compile the same dependencies, thus using the same build folders.
-      # FIXME: A proper fix requires sequentially chaining tablegens.
-      if (NOT ${project} STREQUAL LLVM)
-        add_dependencies(${project}-tablegen-host LLVM-tablegen-host)
-      endif()
       add_custom_command(OUTPUT ${${project}_TABLEGEN_EXE}
         COMMAND ${tblgen_build_cmd}
         DEPENDS CONFIGURE_LLVM_NATIVE ${target}




More information about the llvm-commits mailing list