[PATCH] D55794: [asan] In llvm.asan.globals, allow entries to be non-GlobalVariable and skip over them

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 12:26:48 PST 2018


rjmccall added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:445
+      auto *V = mdconst::extract_or_null<Constant>(MDN->getOperand(0));
+      auto *StrippedV = V->stripPointerCasts();
+      auto *GV = dyn_cast_or_null<GlobalVariable>(StrippedV);
----------------
This will crash if V is actually null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55794/new/

https://reviews.llvm.org/D55794





More information about the llvm-commits mailing list