[PATCH] D55721: llvm-dwarfdump: Improve/fix pretty printing of array dimensions

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Cool, I find these thing really helpful when looking at DWARF output so I'm excited to see them getting more advanced.



================
Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:207
       if (C.getTag() == DW_TAG_subrange_type) {
-        OS << '[';
-        uint64_t LowerBound = 0;
+        Optional<uint64_t> LB;
+        Optional<uint64_t> Count;
----------------
nit: Could we maybe extract this into a static dumpArray helper?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55721/new/

https://reviews.llvm.org/D55721