tablegen reruns on clean builds after r330742

[Nico Weber via llvm-commits]

I accidentally ran into a scenario where I saw a similar effect.
https://reviews.llvm.org/D55842 is a reland with a fix for the issue I was
seeing locally. I don't know if it's what was happening on your end though.
Could you check if that new version works better for you?

On Tue, May 29, 2018 at 11:41 PM Dean Michael Berris <dberris at google.com>
wrote:

> No, I've been doing:
>
> ninja all check-all
>
> or
>
> ninja all check-xray
>
> Versions:
>
> cmake version 3.9.0
> ninja 1.8.2
>
>
> On Wed, May 30, 2018 at 10:41 AM Nico Weber <thakis at chromium.org> wrote:
>
>> That looks reasonably similar to what I have. To confirm, you're
>> basically doing `ninja llc` and then `ninja llc` again and you see compiles
>> happening on the 2nd build?
>>
>> What's your `ninja --version`? What happens if you pass `-d explain` to
>> the 2nd build? What's your cmake version?
>>
>> (Works fine for me with ninja 1.8.2, cmake 3.6.0-rc3)
>>
>> On Tue, May 29, 2018 at 8:13 PM, Dean Michael Berris <dberris at google.com>
>> wrote:
>>
>>> Hi Nico,
>>>
>>> My last cmake build in my zsh history looks like:
>>>
>>> cmake -GNinja -DLLVM_ENABLE_PROJECTS='clang;compiler-rt'
>>> -DCMAKE_C_COMPILER=clang-5.0 -DCMAKE_CXX_COMPILER=clang++-5.0
>>> -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_USE_SPLIT_DWARF=On
>>> -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_USE_LINKER=lld
>>> -DCOMPILER_RT_INCLUDE_TESTS=On -DLLVM_ENABLE_SPHINX=On
>>> -DSPHINX_WARNINGS_AS_ERRORS=On -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DC
>>> MAKE_EXPORT_COMPILE_COMMANDS=ON ../llvm-project/llvm
>>>
>>> I don't necessarily think there's anything special here other than, I'm
>>> using the monorepo:
>>>
>>>
>>> http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo
>>>
>>> Cheers
>>>
>>> On Wed, May 30, 2018 at 5:34 AM Nico Weber <thakis at chromium.org> wrote:
>>>
>>>> Hi Dean and Tim,
>>>>
>>>> I'm not subscribed to llvm-commits, so I didn't see your comments
>>>> re r330742 until just now, apologies. (Thanks to Chandler for reverting in
>>>> the meantime!)
>>>>
>>>> I didn't see this behavior locally, so I'd like to request some more
>>>> information. Which cmake generator are you using? Can you maybe post the
>>>> exact cmake and build commands you use to build llvm?
>>>>
>>>> Thanks,
>>>> Nico
>>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181218/129cef21/attachment.html>