[PATCH] D55670: [RFC] [COFF] [AArch64] Avoid crashing on .seh directives in assembly

Tue Dec 18 10:29:07 PST 2018

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.

================
Comment at: test/MC/AArch64/seh.s:75
+
+// Test emission of small functions.
+    .globl smallFunc
----------------
rnk wrote:
> This is the one that misbehaves, because it has no end prologue, right?
Not entirely sure, or if there's sonething else that isn't properly hooked up wrt SEH in the MC layer for aarch64. I noticed that there's lots of `.seh_*` directives for x86_64 that aren't available for aarch64 yet (although I guess some of them are arch specific).

Adding `.seh_endprologue` here isn't enough to make it not crash before this patch at least.

The real case where I ran into it was https://github.com/mirror/mingw-w64/blob/master/mingw-w64-crt/crt/crtexe.c#L185 though.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55670/new/

https://reviews.llvm.org/D55670