[PATCH] D53384: [PowerPC] Make no-PIC default to match GCC - CLANG

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 07:17:57 PST 2018


sfertile added inline comments.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp:2438
   case llvm::Triple::ppc64:
-  case llvm::Triple::ppc64le:
+    // Big endian PPC is PIC by default
     return !getTriple().isOSBinFormatMachO() && !getTriple().isMacOSX();
----------------
I think you should mention // why // BE has to remain pic by default in this comment.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53384/new/

https://reviews.llvm.org/D53384





More information about the llvm-commits mailing list