[PATCH] D55760: [ADT] IntervalMap: add contains(a, b) method

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 07:05:45 PST 2018


dexonsmith added inline comments.


================
Comment at: unittests/ADT/IntervalMapTest.cpp:622
+  EXPECT_FALSE(map.overlaps(0, 9));
+  EXPECT_TRUE(map.overlaps(0, 10));
+  EXPECT_TRUE(map.overlaps(0, 15));
----------------
I’m surprised this one returns true.  Are these half-open intervals?  If so I think you shouldn’t get overlap until you stop at 11.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55760/new/

https://reviews.llvm.org/D55760





More information about the llvm-commits mailing list