[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 06:46:38 PST 2018


probinson added a comment.

In D55281#1333802 <https://reviews.llvm.org/D55281#1333802>, @dblaikie wrote:

> Still a bit curious about the other discussion about flags, etc.


Well, you have better access to Eric than the rest of us....
Certainly having cl::opt flags makes it easier to test things in a non-platform-dependent way, if nothing else.  I can see putting all the ptxas-special stuff under a single "use-ptxas-format" flag instead of several different ones.  It makes the control less feature-oriented, but more obvious about the purpose/intent.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281





More information about the llvm-commits mailing list