[PATCH] D55423: [LLD][ELF] - A fix for "linker script assignment loses relative nature of section" bug.

Tue Dec 18 02:53:44 PST 2018

grimar added a comment.

In D55423#1333787 <https://reviews.llvm.org/D55423#1333787>, @ruiu wrote:

> I think I'm not still convinced that we should support forward declaration. How often do you really need that? Also, how is it hard/easy to detect if something is a forward reference? How much easy/hard to fix your linker scripts if yours is already using that pattern?
>
> I believe we should at least ban circular definitions such as `foo=bar; bar=foo;` because it doesn't make any sense.

I am not trying to support the forward declaration. We already do that (example: addr-zero.test).
I think it is a bit hard to detect that given the approach we have (define all linker script symbols early) and I am not sure we should care.
Some of the scripts in the wild (including apps in the BSD world) were using it already and that is why we supported that initially, I think.
Scripts require careful use anyways.

Please take a look at the https://reviews.llvm.org/D55550 first. I think D55550 <https://reviews.llvm.org/D55550> is a very reasonable change.
With the D55550 <https://reviews.llvm.org/D55550>, this patch becomes really trivial/natural.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55423/new/

https://reviews.llvm.org/D55423