[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 17 11:43:53 PST 2018


ABataev added a comment.

NVPTX does not support labels in the debug info sections. All these new labels must be created/emitted only if `DwarfDebug::useSectionsAsReferences()` is `false`.



================
Comment at: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfFile.cpp:50
+
+  Asm->OutStreamer->EmitLabel(TheU->getEndLabel());
 }
----------------
This also must not be emitted for NVPTX.


================
Comment at: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1559
+  MCSymbol *BeginLabel = Asm->createTempSymbol(Prefix + "start");
+  EndLabel = Asm->createTempSymbol(Prefix + "end");
+
----------------
Labels are not supported by the NVPTX at all, you should not emit them unconditionally.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281





More information about the llvm-commits mailing list