[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 16 03:46:00 PST 2018


delcypher added a comment.

In D55740#1332340 <https://reviews.llvm.org/D55740#1332340>, @krytarowski wrote:

> In D55740#1332339 <https://reviews.llvm.org/D55740#1332339>, @delcypher wrote:
>
> > In D55740#1332296 <https://reviews.llvm.org/D55740#1332296>, @krytarowski wrote:
> >
> > > I propose to keep UNSUPPORTED for tests that are not applicable for Darwin or are randomly hanging/crashing.
> >
> >
> > Are you saying you'd rather I use XFAIL?
>
>
> Yes, unless a test is flaky and produces random success.


Okay. I'll change it. The intention is that I'll fix these tests at a later date because some of the failures look like real bugs to me.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740





More information about the llvm-commits mailing list