[PATCH] D55738: [FileCheck] Annotate input dump (final tweaks)

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 15 05:52:10 PST 2018


jdenny created this revision.
jdenny added a reviewer: probinson.
Herald added subscribers: kristina, hiraditya.

Apply final suggestions from probinson for this patch series plus a
few more tweaks:

- Improve various docs, for MatchType in particular.

- Rename some members of MatchType.  The main problem was that the term "final match" became a misnomer when CHECK-COUNT-<N> was created.

- Split InputStartLine, etc. declarations into multiple lines.

This patch doesn't necessarily require a review, but I wanted to put it in phabricator for safe keeping while waiting for D53899 <https://reviews.llvm.org/D53899> to be accepted.


Repository:
  rL LLVM

https://reviews.llvm.org/D55738

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55738.178359.patch
Type: text/x-patch
Size: 9784 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181215/6085ddca/attachment.bin>


More information about the llvm-commits mailing list