[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 10:47:31 PST 2018


On Fri, Dec 14, 2018 at 01:27:14AM +0000, Eric Christopher via Phabricator via llvm-commits wrote:
> Joerg: We asked some very specific questions to which there don't
> appear to be answers coming from you and this patch doesn't affect any
> other target negatively here. Unless you come up with a compelling
> argument not to commit this other than "some platforms have support
> for this in other places" I think we need to commit this.

I have no idea what else I can say other than "This is not a generic
implementation. Please do not pretend it to be one". Even more so that I
strongly believe that especially GNU should gets its act together and
ship a working copy with glibc.

Joerg


More information about the llvm-commits mailing list