[PATCH] D55681: [llvm] API for encoding/decoding DWARF discriminators.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 08:51:31 PST 2018


mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1607
+  static unsigned encodeDiscriminator(unsigned BD, unsigned DF, unsigned CI,
+                                      bool &Success) {
+    SmallVector<unsigned, 3> Components = {BD, DF, CI};
----------------
aprantl wrote:
> Could you please move all the implementations to DebugInfoMetadata.cpp ?
Thanks - I assume you were referring to the new encode/decode pair. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55681/new/

https://reviews.llvm.org/D55681





More information about the llvm-commits mailing list