[PATCH] D54749: Saturating float to int casts: Basics [1/n]

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 01:22:19 PST 2018


RKSimon added a comment.

It might be better to split the test files into fptosi-sat-*.ll and fptoui-sat-*.ll



================
Comment at: test/CodeGen/X86/fptoi-sat-scalar.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-linux < %s | FileCheck %s
+
----------------
Please add i686 coverage:
```
; RUN: llc < %s -mtriple=i686-linux | FileCheck %s --check-prefix=X86,X86-X87
; RUN: llc < %s -mtriple=i686-linux -mattr=+sse2 | FileCheck %s --check-prefix=X86,X86-SSE
; RUN: llc < %s -mtriple=x86_64-linux | FileCheck %s --check-prefix=X64
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749





More information about the llvm-commits mailing list