[PATCH] D54143: [RISCV] Generate address sequences suitable for mcmodel=medium

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 00:47:53 PST 2018


rogfer01 added a comment.

In D54143#1325501 <https://reviews.llvm.org/D54143#1325501>, @lewis-revill wrote:

> Rebased and updated to use and expand `PseudoLLA` for PC-relative addressing.


Ah, now I understand! I always forget one can create target nodes here :) Definitely using `PseudoLLA` is more straightforward.

Overall the approach looks sensible to me: if `RISCVExpandPseudoInsts.cpp` is late enough for subword compare-and-exchange pseudos (which have to be carefully emitted, AFAIU) it should be too for the expansion of `PseudoLLA` (and `PseudoLA`).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54143/new/

https://reviews.llvm.org/D54143





More information about the llvm-commits mailing list