[PATCH] D54783: [Power9] suboptimal vec_abs for some cases

[Kewen Lin via Phabricator via llvm-commits]

jedilyn marked an inline comment as done.
jedilyn added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-P9-vabsd.ll:5
 
-; Function Attrs: nounwind readnone
 define <4 x i32> @simple_absv_32(<4 x i32> %a) local_unnamed_addr {
----------------
jsji wrote:
> Why we remove Function Attrs here? If this is no relevant clean up work, please do it in a NFC patch before this. Thanks.
I was told that don't keep those irrelevant attributes in the ll case and only leave what is really necessary, I tried to follow it and believed they aren't required for this case, so I cleaned it when updated this file. Good idea to make it in a NFC patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54783/new/

https://reviews.llvm.org/D54783