[PATCH] D55542: [llvm-xray] Support for PIE

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 17:22:43 PST 2018


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:105
+          continue;
+        auto AddendOrErr = object::ELFRelocationRef(Reloc).getAddend();
+        if (AddendOrErr)
----------------
It can be simplified with
`if (auto AddendOrErr = object::ELFRelocationRef(Reloc).getAddend())`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55542/new/

https://reviews.llvm.org/D55542





More information about the llvm-commits mailing list