[PATCH] D54743: SROA: preserve alignment tags on loads and stores.

Gerolf Hoflehner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 13:37:36 PST 2018


Gerolf added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:3294
+                   AAMDNodes AATags, unsigned BaseAlign, const DataLayout &DL)
+        : OpSplitter<LoadOpSplitter>(InsertionPoint, Ptr, BaseTy, AATags,
+                                     BaseAlign, DL) {}
----------------
Do you need the BaseAlign parameter? It seems at all instances it could be computed inside the OpSplitter from the InsertionPoint and DL using getAdjustedAlignment().


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54743/new/

https://reviews.llvm.org/D54743





More information about the llvm-commits mailing list