[PATCH] D55503: Change llvm call once check for building Swift for PowerPC(ppc64le)

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 07:59:01 PST 2018


nemanjai added a comment.

In D55503#1329617 <https://reviews.llvm.org/D55503#1329617>, @sarveshtamba wrote:

> The Swift 5.0 toolchain on PowerPC64LE also works fine if we remove the "defined(ppc)" check altogether in the original code i.e keep only "!(defined(__NetBSD__) || defined(__OpenBSD__)))".
>  Would that affect other PPC platforms (32/64 and BE/LE PPC other than PowerPC64LE)?


Oh I see. What you are suggesting is that on PPC64LE we *want to use std::call_once*. Basically, get rid of the workaround for PPC64LE. That seems in direct contrast to what this code was originally meant to do then doesn't it? In any case, it would require fairly extensive testing of affected code before we could commit such a change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55503/new/

https://reviews.llvm.org/D55503





More information about the llvm-commits mailing list