[PATCH] D55622: [Sanitize] capsicum further support of the API

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 13 06:25:26 PST 2018


emaste added a comment.

Aside from question about `#include` ordering LGTM



================
Comment at: test/sanitizer_common/TestCases/FreeBSD/capsicum.cc:7-8
+#include <string.h>
 #include <sys/capsicum.h>
 #include <sys/ioctl.h>
 #include <termios.h>
----------------
This ordering seems odd


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55622/new/

https://reviews.llvm.org/D55622





More information about the llvm-commits mailing list