[PATCH] D55642: [X86] Fix assert fails in pass X86AvoidSFBPass

Thu Dec 13 04:15:56 PST 2018

nikic added inline comments.

================
Comment at: lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:646
+  for (auto DispSizePair = BlockingStoresDispSizeMap.begin();
        DispSizePair != BlockingStoresDispSizeMap.end(); ++DispSizePair) {
     int64_t CurrDisp = DispSizePair->first;
----------------
This can be a range-based for loop now.

================
Comment at: test/CodeGen/X86/pr38743.ll:1
+; RUN: llc < %s
+
----------------
Could you please also include the generated assembly? This can be done by running `utils/update_llc_test_checks.py test/CodeGen/X86/pr38743.ll`. Possibly with a `--llc-bin build/bin/llc` argument, or similar.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55642/new/

https://reviews.llvm.org/D55642