[PATCH] D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D55263#1327772 <https://reviews.llvm.org/D55263#1327772>, @pcordes wrote:

> In D55263#1325283 <https://reviews.llvm.org/D55263#1325283>, @davezarzycki wrote:
>
> > Let's not lose sight of the big picture here. If uarch problems exist, are they *worse* than the cost of calling memcmp()?
>
>
> Almost certainly no, even for memcpy where potential store-forwarding stalls or 4k aliasing are a pretty minor concern most of the time.
>
> I pointed those things out so the new unaligned load/store code-gen can be the best it can be while people are working on that code anyway, *not* because I think there's a risk of overall regressions.


+1

I always find Peter's comments very useful/informative.
I don't think that anybody is losing sight of the big picture here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55263/new/

https://reviews.llvm.org/D55263