[PATCH] D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In D54904#1326133 <https://reviews.llvm.org/D54904#1326133>, @vitalybuka wrote:

> And for where ever it's going to be used, would be nice to have at least draft/WIP patch in the stack to see how this is going to be used


I've avoided doing this thus far for several reasons:

- Creating lots of patches further divides your team's limited review time.
- If changes are requested to patches low in the stack of patches, then this will likely require changes to many patches higher in stack, and possibly even a complete rethink of the approach. This rewriting can burn a lot of time so I prefer to rewrite just one or two patches at a time rather than a large patch set to avoid this.

I think this patch is much closer to something that your team will accept so I'll start creating more patches that tries to follow the style of this patch. I'll put these up for review today.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54904/new/

https://reviews.llvm.org/D54904