[PATCH] D55573: [MachO][TLOF] Add support for local symbols in the indirect symbol table

Gerolf Hoflehner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 19:38:02 PST 2018


Gerolf added inline comments.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1122
   MachineModuleInfoImpl::StubValueTy &StubSym = MachOMMI.getGVStubEntry(Stub);
-  if (!StubSym.getPointer())
-    StubSym = MachineModuleInfoImpl::
-      StubValueTy(const_cast<MCSymbol *>(Sym), true /* access indirectly */);
+  if (!StubSym.getPointer()) {
+    bool IsIndirectLocal = Sym->isDefined() && !Sym->isExternal();
----------------
Please add the comment from radar about this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55573/new/

https://reviews.llvm.org/D55573





More information about the llvm-commits mailing list