[PATCH] D52999: [FileCheck] Annotate input dump (1/7)

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 15:18:42 PST 2018


jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:167
+  /// The search range.
+  unsigned InputStartLine, InputStartCol, InputEndLine, InputEndCol;
+  FileCheckDiag(const SourceMgr &SM, const Check::FileCheckType &CheckTy,
----------------
probinson wrote:
> The style guide doesn't actually say this, but it's pretty much universal in the code base to declare each member separately.
Ah, I missed that.  I'll get it before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52999/new/

https://reviews.llvm.org/D52999





More information about the llvm-commits mailing list