[PATCH] D55080: [ThinLTO] Out-of-process CodeGenerator for legacy C API

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D55080#1328556 <https://reviews.llvm.org/D55080#1328556>, @steven_wu wrote:

> Ping. Is there any comments of implementing C API in this approach?


Sorry for not responding earlier. I'll take a closer look this week, but a couple of high level questions below. I also added @pcc for thoughts.

Can you give a description of how this interacts with your distributed build system? I see references to something called XPC, but I don't know what that is. Is this something that is Apple build system specific? AFAICT btw this approach would not work with our build system, although we are using the new LTO API so not affected directly. But I have a concern that this may make it harder to migrate the old to the new LTO API, but hopefully it can be designed so that the two approaches could both be supported in a single LTO API.

Regarding linker changes, the only linker changes required by our distributed build approach is to exit the linker early (after the thin link), and to write out the individual index files (which is actually handled within the new LTO API so not much needs to be done in the linker for that). Presumably you could do that latter part inside the old LTO API as well (as you are doing here in this patch).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55080/new/

https://reviews.llvm.org/D55080