[PATCH] D52999: [FileCheck] Annotate input dump (1/7)

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A couple of nits I didn't notice until looking at the next patch.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:162
+    // TODO: More members will appear with later patches in this series.
+    /// no match for an expected pattern
+    MatchNoneButExpected,
----------------
Comments should be proper sentences.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:167
+  /// The search range.
+  unsigned InputStartLine, InputStartCol, InputEndLine, InputEndCol;
+  FileCheckDiag(const SourceMgr &SM, const Check::FileCheckType &CheckTy,
----------------
The style guide doesn't actually say this, but it's pretty much universal in the code base to declare each member separately.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52999/new/

https://reviews.llvm.org/D52999