[PATCH] D55590: [CostModel][X86] Don't count 2 shuffles on the last level of a pairwise arithmetic or min/max reduction

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 06:43:14 PST 2018


ABataev added inline comments.


================
Comment at: include/llvm/CodeGen/BasicTTIImpl.h:1434
+        // case two soure permute on a wide illegal type.
+        std::pair<unsigned, MVT> ShufLT =
+          ConcreteTTI->getTLI()->getTypeLegalizationCost(DL, Ty);
----------------
Is this really required for this patch? I think not. This patch should do only the declared thing - fix of the cost, nothing else. This change is not required for the fix of the cost model.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55590/new/

https://reviews.llvm.org/D55590





More information about the llvm-commits mailing list