[PATCH] D55503: Change llvm call once check for building Swift for PowerPC(ppc64le)

Sarvesh Tamba via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 01:46:45 PST 2018


sarveshtamba added a comment.

As per the comments in the code:-

// std::call_once from libc++ is used on all Unix platforms. Other
// implementations like libstdc++ are known to have problems on NetBSD,
// OpenBSD and PowerPC.

There were some crashes seen when std::call_once was used on PowerPC64LE. There is a macro check already for PPC (i.e "!(defined(__NetBSD__) || defined(__OpenBSD__) || defined(__ppc__)))" ). However this check is not enough(since ppc could conceivably be 32-bit PPC as well). Hence this patch checks for PPC as well as LITTLE_ENDIAN which is the case for PowerPC64LE and further works fine without any issues on this platform.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55503/new/

https://reviews.llvm.org/D55503





More information about the llvm-commits mailing list