[PATCH] D49281: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 21:27:17 PST 2018


Meinersbur updated this revision to Diff 177820.
Meinersbur added a comment.

- [test] Revise tests
  - Consistent disable_nonforced testing
  - Unify followup-attribute testing. The previous approach was to copy existing test cases and emulate the behavior of the loop transformation passes using followup attributes. This had the disadvantage that the pass would pass even if the followup-attribute was ignored (indeed, some were misspelled) since the result is the same. Instead, use a new "followup.ll" test per loop pass that checks the presence of new attributes specific for each followup.
- [docs] Add followup attribute recommendations


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49281/new/

https://reviews.llvm.org/D49281

Files:
  docs/LangRef.rst
  docs/Passes.rst
  docs/TransformMetadata.rst
  docs/index.rst
  include/llvm/InitializePasses.h
  include/llvm/LinkAllPasses.h
  include/llvm/Transforms/Scalar.h
  include/llvm/Transforms/Scalar/WarnMissedTransforms.h
  include/llvm/Transforms/Utils/LoopUtils.h
  include/llvm/Transforms/Utils/UnrollLoop.h
  include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h
  lib/Analysis/LoopInfo.cpp
  lib/Passes/PassBuilder.cpp
  lib/Passes/PassRegistry.def
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Scalar/CMakeLists.txt
  lib/Transforms/Scalar/LoopDistribute.cpp
  lib/Transforms/Scalar/LoopUnrollAndJamPass.cpp
  lib/Transforms/Scalar/LoopUnrollPass.cpp
  lib/Transforms/Scalar/LoopVersioningLICM.cpp
  lib/Transforms/Scalar/Scalar.cpp
  lib/Transforms/Scalar/WarnMissedTransforms.cpp
  lib/Transforms/Utils/LoopUnroll.cpp
  lib/Transforms/Utils/LoopUnrollAndJam.cpp
  lib/Transforms/Utils/LoopUnrollRuntime.cpp
  lib/Transforms/Utils/LoopUtils.cpp
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Other/new-pm-defaults.ll
  test/Other/new-pm-thinlto-defaults.ll
  test/Other/opt-O2-pipeline.ll
  test/Other/opt-O3-pipeline.ll
  test/Other/opt-Os-pipeline.ll
  test/Other/opt-hot-cold-split.ll
  test/Transforms/LoopDistribute/disable_nonforced.ll
  test/Transforms/LoopDistribute/disable_nonforced_enable.ll
  test/Transforms/LoopDistribute/followup.ll
  test/Transforms/LoopTransformWarning/distribution-remarks-missed.ll
  test/Transforms/LoopTransformWarning/unrollandjam-remarks-missed.ll
  test/Transforms/LoopTransformWarning/unrolling-remarks-missed.ll
  test/Transforms/LoopTransformWarning/vectorization-remarks-missed.ll
  test/Transforms/LoopUnroll/disable_nonforced.ll
  test/Transforms/LoopUnroll/disable_nonforced_count.ll
  test/Transforms/LoopUnroll/disable_nonforced_enable.ll
  test/Transforms/LoopUnroll/disable_nonforced_full.ll
  test/Transforms/LoopUnroll/followup.ll
  test/Transforms/LoopUnrollAndJam/disable_nonforced.ll
  test/Transforms/LoopUnrollAndJam/disable_nonforced_count.ll
  test/Transforms/LoopUnrollAndJam/disable_nonforced_enable.ll
  test/Transforms/LoopUnrollAndJam/followup.ll
  test/Transforms/LoopUnrollAndJam/pragma.ll
  test/Transforms/LoopVectorize/X86/vectorization-remarks-missed.ll
  test/Transforms/LoopVectorize/disable_nonforced.ll
  test/Transforms/LoopVectorize/disable_nonforced_enable.ll
  test/Transforms/LoopVectorize/followup.ll
  test/Transforms/LoopVectorize/no_array_bounds.ll
  test/Transforms/LoopVectorize/no_switch.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49281.177820.patch
Type: text/x-patch
Size: 145424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181212/561059bd/attachment.bin>


More information about the llvm-commits mailing list