[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

Naoki Shibata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 19:51:41 PST 2018


shibatch added a comment.

> A header file that wasn't there before is now automagically included, and there's nothing they can do to not include it. Boom! - source code change. Happy re-certification planning.

@steleman Could you explain a little bit about when a re-certification is required?
Is it required when a standard header file(e.g. math.h) is changed?

gcc/glibc is doing a similar thing. In math-vector.h, which is included from math.h, there is declaration like below.

  # if defined _OPENMP && _OPENMP >= 201307
  /* OpenMP case.  */
  #  define __DECL_SIMD_x86_64 _Pragma ("omp declare simd notinbranch")
  # elif __GNUC_PREREQ (6,0)
  /* W/o OpenMP use GCC 6.* __attribute__ ((__simd__)).  */
  #  define __DECL_SIMD_x86_64 __attribute__ ((__simd__ ("notinbranch")))
  # endif
  
  # ifdef __DECL_SIMD_x86_64
  #  undef __DECL_SIMD_cos
  #  define __DECL_SIMD_cos __DECL_SIMD_x86_64
  ...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927





More information about the llvm-commits mailing list