[PATCH] D55236: [codeview] Look through typedefs in getCompleteTypeIndex

Tue Dec 11 15:01:52 PST 2018

rnk marked an inline comment as done.
rnk added a comment.

In D55236#1318552 <https://reviews.llvm.org/D55236#1318552>, @aganea wrote:

> > Fixes PR39853.
>
> The issue I was discussing with Zachary occurs when using cl-generated OBJs with LLD (we haven't deployed clang in production yet).
>  Shouldn't there be something in LLD to completly fix PR39853?  Microsoft seems to be doing a post-merge pass to resolve forward-declared UDTs, see here <https://github.com/Microsoft/microsoft-pdb/blob/082c5290e5aff028ae84e43affa8be717aa7af73/PDB/dbi/mod.cpp#L2286> and here <https://github.com/Microsoft/microsoft-pdb/blob/082c5290e5aff028ae84e43affa8be717aa7af73/PDB/dbi/mod.cpp#L2795>.

I guess it depends how we want to scope the PR. I'll just say this fixes the compiler side of it, i.e. makes clang generate the same debug info as msvc.

================
Comment at: llvm/test/DebugInfo/COFF/udts-complete.ll:13
+; typedef Bar Baz;
+; static_assert(sizeof(Foo) == 8, "");
+; Baz gv;
----------------
aganea wrote:
> `== 4`?
Heh, I think I actually commented that out and compiled with -fstandalone-debug, which you can see below from `emissionKind: FullDebug`. I'll fix it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55236/new/

https://reviews.llvm.org/D55236