[PATCH] D55147: Exclude non-integral pointers in isBytewiseValue

[Cherry Zhang via Phabricator via llvm-commits]

cherry marked 2 inline comments as done.
cherry added inline comments.


================
Comment at: include/llvm/Analysis/ValueTracking.h:227
   /// return undef.
-  Value *isBytewiseValue(Value *V);
+  Value *isBytewiseValue(Value *V, const DataLayout &DL = DataLayout(""));
 
----------------
cherry wrote:
> efriedma wrote:
> > cherry wrote:
> > > Provided a default value as this function is public so it won't break external uses. External uses probably don't care about non-integral pointer anyway. (E.g. clang has one use.)
> > > 
> > I'd prefer not to do this; constructing a DataLayout like this is probably sort of expensive.  It's not a big deal to update clang.
> Ok, will do.
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55147/new/

https://reviews.llvm.org/D55147