[PATCH] D55547: [ConstantInt] Check active bits before calling getZExtValue.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 11:40:57 PST 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM; arrays/struct types are currently limited to 2^64 elements anyway.

> should we update getAggregateElement to take an uin64_t as well?

Yes, all the ConstantAggregate-related code should use uint64_t to match the type system.  See also https://reviews.llvm.org/D55169, where this just came up.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55547/new/

https://reviews.llvm.org/D55547





More information about the llvm-commits mailing list