[PATCH] optimised/generalised __udivmoddi4.c

Stefan Kanthak via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 10:44:21 PST 2018


"Roman Lebedev" <lebedev.ri at gmail.com> wrote:

> On Tue, Dec 11, 2018 at 8:58 PM Stefan Kanthak via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> LLVM/clang inlines "long" shifts, so __udivmoddi4.c doesn't need
>> several if...then...else...if...then...else clauses and can be
>> simplified, yielding shorter and faster code.
> Can you please submit these patches via the phabricator please, every
> review is done via it.
> https://llvm.org/docs/Phabricator.html

Citing that page:

| If you prefer to use a web user interface for code reviews, ...

I don't prefer a web interface, I prefer plain old SMTP [*]!

| While Phabricator is a useful tool for some, the relevant -commits
| mailing list is the system of record for all LLVM code review.

Phabricator is no useful tool for me.

[*] <https://llvm.org/docs/DeveloperPolicy.html>
| Once your patch is ready, submit it by emailing it to the appropriate
| project's commit mailing list (or commit it directly if applicable).
| Alternatively, some patches get sent to the project's development list
| or component of the LLVM bug tracker, but the commit list is the
                                            ~~~~~~~~~~~~~~~~~~~~~~
| primary place for reviews and should generally be preferred.
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

According to LLVM's own documentation, submission of patches via
*-commits is the preferred method.

Stefan


More information about the llvm-commits mailing list