[PATCH] D55279: [RISCV] Support assembling %got_pcrel_hi operator

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 08:39:30 PST 2018


jrtc27 marked an inline comment as done.
jrtc27 added a comment.

Slight annoying bit of churn turning `getPCRelHiExpr` into `getPCRelHiFixup` (when I tweaked D54029 <https://reviews.llvm.org/D54029> I simply didn't make `shouldForceRelocation` give an error for a null `getPCRelHiExpr` return value, and therefore it could remain unchanged, but with the increased error checking we now need to get the entire `MCFixup` back).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55279/new/

https://reviews.llvm.org/D55279





More information about the llvm-commits mailing list