[PATCH] D55550: [LLD][ELF] - Fix the different behavior of the linker script symbols on different platforms.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D55550#1326818 <https://reviews.llvm.org/D55550#1326818>, @peter.smith wrote:

> Overall I'm happy with this change as I think it is simpler than adding another call to Writer<ELFT>::run(). The one remaining thought is whether Writer<ELFT>::run() can be moved into finalizeAddressDependentContent() as there shouldn't be anything after that function that changes address. Could we move the remaining Writer<ELFT>::run() to the end of finalizeAddressDependentContent() ?


I am not sure honestly. I like that we do not spread and have all the `finalizeSynthetic` in one place (in one method) and I
like that `finalizeAddressDependentContent` is an isolated piece where the iteration magic happens.
I would probably try to avoid adding the additional code into it. This patch only removes the code from there
and I think it is good.

But If we decide to do something like this, I would suggest doing it in a different patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55550/new/

https://reviews.llvm.org/D55550