[PATCH] D54740: [NewPM] fixing asserts on deleted loop in -print-after-all

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

Thanks, this does LGTM!

One additional thought though, and if this doesn't make sense to you feel free to commit:

In case the IRUnit has been invalidated, can we //still// pass it to the callback? When I think of instrumentations that do more complicated things than printing, it's highly likely that they would like to be notified when an IRUnit handle becomes invalid. Which requires passing the handle. If we are passing the handle, though, we need to emphasize that the unit isn't accessible through the handle anymore. Maybe by passing `void*` instead, or some tag type `Invalidated<T> { void* Handle; }`. The latter can go through the `any` and allow deducing the actual IRUnit type.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54740/new/

https://reviews.llvm.org/D54740