[PATCH] D55227: [DebugInfo] Don't drop dbg.value's of nullptr

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 03:42:39 PST 2018


jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/InstrEmitter.cpp:739
+    } else if (isa<ConstantPointerNull>(V)) {
+      // Null pointer constants are zero-valued.
+      MIB.addImm(0);
----------------
aprantl wrote:
> How about: `//Note: This assumes that all nullptr constants are zero-valued.`
Replacing with this in the commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55227/new/

https://reviews.llvm.org/D55227





More information about the llvm-commits mailing list